pantsbuild
/
pants
/
5989
/
2
0%
main: 93%
main: 93%
|
Ran
|
Files
348
|
Run time
9s
|
Badge
Embed ▾
README BADGES
|
coverage: 68.97%. Remained the same
push
travis-ci
jsiroisUpgrade pex to 1.0.2. Changelog is here: https://pypi.python.org/pypi/pex/1.0.2 Notably, this picks up a fix for PEX-INFO trampling as outlined here: https://groups.google.com/d/topic/pants-devel/CuAV8AO0Hbg/discussion Testing Done: I confirmed zip_safe now sticks using a modified pants local python_binary target: ```diff $ git diff -U1 diff --git a/src/python/pants/bin/BUILD b/src/python/pants/bin/BUILD index a937b3a..4425d33 100644 --- a/src/python/pants/bin/BUILD +++ b/src/python/pants/bin/BUILD @@ -54,2 +54,3 @@ python_binary( ], + zip_safe=False, ) ``` This both embedded and respected the embedded zip_safe flag: ```console $ ./pants binary src/python/pants/bin:pants_local_binary $ unzip -qc dist/pants_local_binary.pex PEX-INFO | python -mjson.tool | grep zip_safe "zip_safe": false $ PEX_VERBOSE=5 ./dist/pants_local_binary.pex --version 2>&1 | grep "zip safe" pex: PEX is not zip safe, exploding to /home/jsirois/.pex/code/26fc51563 ``` CI is away here: https://travis-ci.org/pantsbuild/pants/builds/74151804 Bugs closed: 1922 Reviewed at https://rbcommons.com/s/twitter/r/2571/
14363 of 20825 relevant lines covered (68.97%)
0.69 hits per line
