7
66%
master: 66%

Ran 20 Jan 2021 01:15AM CUT

Files 110

Run time 14s

Badge

Embed ▾

Committed 20 Jan 2021 12:38AM CUT coverage: 65.365% (+0.007%) from 65.358%

Job # TESTFLAGS="--coverage" CONTAINER="netaccess"

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Detect redirect loops in VA (#5234)

Currently the VA checks to see how many redirects have been followed and
bails out if greater than maxRedirect (10), but it does not check to see
if any redirect url has been followed twice which would mean a broken
infinite redirect loop. Storing the validation records for these is
relatively expensive because we store a record for each hop in the
redirect.

This change checks the previous redirect records to see if the URL has
been used before and error if it has. This will catch a redirect loop
earlier than the maxRedirect value in most cases.

Fixes #5224

Run Details

13292 of 20335 relevant lines covered (65.37%)

0.73 hits per line

Source Files on job 13286.7 (TESTFLAGS="--coverage" CONTAINER="netaccess")

File	Lines	Relevant	Missed
grpc/ca-wrappers.go	70	30	30
grpc/publisher-wrappers.go	53	18	18
cmd/boulder-wfe/main.go	218	117	117
db/transaction.go	28	15	15
cmd/clock_generic.go	15	3	3
cmd/boulder-publisher/main.go	110	65	65
cmd/boulder-va/main.go	185	117	117
cmd/boulder-sa/main.go	97	62	62
cmd/boulder-ra/main.go	267	147	147
grpc/ra-wrappers.go	343	246	246

86.75
akamai/
68.2
bdns/
80.52
ca/
100.0
canceled/
43.79
cmd/
69.79
core/
91.23
csr/
73.37
ctpolicy/
74.51
db/
10.0
errors/
93.94
features/
78.07
goodkey/
29.99
grpc/
100.0
iana/
59.05
issuance/
16.46
lint/
91.0
log/
69.7
mail/
68.18
metrics/
94.38
nonce/
64.57
ocsp/
62.9
pkcs11helpers/
91.59
policy/
54.5
probs/
90.46
publisher/
83.1
ra/
68.82
ratelimit/
89.8
reloader/
77.9
sa/
40.18
test/
92.69
va/
65.22
web/
78.34
wfe/
82.14
wfe2/

letsencrypt / boulder / 13286 / 7
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13286.7 (TESTFLAGS="--coverage" CONTAINER="netaccess")

letsencrypt / boulder / 13286 / 7 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13286.7 (TESTFLAGS="--coverage" CONTAINER="netaccess")

letsencrypt / boulder / 13286 / 7
66%
master: 66%

README BADGES
x