pantsbuild
/
pants
/
5859
/
2
0%
main: 93%
main: 93%
|
Ran
|
Files
342
|
Run time
15s
|
Badge
Embed ▾
README BADGES
|
coverage: 67.956% (-0.001%) from 67.957%
push
travis-ci
Garrett Malmquist
Declaring product_types for simple_codegen_task. This is a hack to get the round manager to properly run codegen before resolve and compile. It would be more correct to just have each individual codegen class declare what languages it generates, but would cause problems with scala. Background (discussed on slack): commit a8a73797a broke Square's java repo, because it removed the last task outside of contrib that provided the 'java' product. The old `CodeGen` used a hack to claim to generate all relevant product types, to get around problems with the round engine. This introduces that hack into simple_codegen_task.py, fixing the regression. Hopefully the underlying problems in round engine will be fixed eventually, and this hack can go away. Testing Done: CI went green: https://travis-ci.org/pantsbuild/pants/builds/73099770 Bugs closed: 1878 Reviewed at https://rbcommons.com/s/twitter/r/2540/
13884 of 20431 relevant lines covered (67.96%)
0.68 hits per line
