1
59%
master: 90%

Ran 28 Jul 2015 07:26PM UTC

Files 24

Run time 1s

Badge

Embed ▾

Committed 28 Jul 2015 06:26PM UTC coverage: 60.794%. First build

Job # 228.1

Build Type

push

travis-ci

Committed by

sectioneight

Commit Message

Fix regression in posting comments

Introduced in c9ca27b, I was using the "diff" ID instead of the "revision" ID
when trying to post a comment.

I'm not super happy about the separation of concerns here and am open to
alternate approaches / suggestions for improvement.

I thought about making DifferentialClient fetch the Differential on
instantiation and store a reference, then calling `getRevisionID(false)`
internally when it wants to `postComment`, but that felt like unnecessary
coupling, and I didn't like the side-effect of fetching on instantiation.

Run Details

383 of 630 relevant lines covered (60.79%)

3.38 hits per line

uber / phabricator-jenkins-plugin / 228 / 1
59%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 228.1

uber / phabricator-jenkins-plugin / 228 / 1 59% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 228.1

uber / phabricator-jenkins-plugin / 228 / 1
59%
master: 90%

README BADGES
x