228
59%
master: 90%

Ran 28 Jul 2015 07:26PM UTC

Jobs 3

Files 21

Run time 5min

Badge

Embed ▾

pending completion

Build # 228

Build Type

push

travis-ci

Committed by

sectioneight

Commit Message

Fix regression in posting comments

Introduced in c9ca27b, I was using the "diff" ID instead of the "revision" ID
when trying to post a comment.

I'm not super happy about the separation of concerns here and am open to
alternate approaches / suggestions for improvement.

I thought about making DifferentialClient fetch the Differential on
instantiation and store a reference, then calling `getRevisionID(false)`
internally when it wants to `postComment`, but that felt like unnecessary
coupling, and I didn't like the side-effect of fetching on instantiation.

Run Details

395 of 672 relevant lines covered (58.78%)

9.55 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	228.1	28 Jul 2015 07:26PM UTC	60.79	Travis Job 228.1
2	228.2	28 Jul 2015 07:26PM UTC	60.79	Travis Job 228.2
3	228.3	28 Jul 2015 07:31PM UTC	58.9	Travis Job 228.3

Source Files on build 228

Detailed source file information is not available for this build.

uber / phabricator-jenkins-plugin / 228
59%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 228

uber / phabricator-jenkins-plugin / 228 59% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 228

uber / phabricator-jenkins-plugin / 228
59%
master: 90%

README BADGES
x