3
0%
main: 93%

Ran 23 Jul 2015 03:28AM UTC

Files 340

Run time 4191min

Badge

Embed ▾

Committed 23 Jul 2015 03:25AM UTC coverage: 66.64% (+0.5%) from 66.176%

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by John Sirois

Commit Message

Fixup SetupPy handling of exported thrift.

SetupPy was attempting to create a PythonThriftBuilder with an invalid
set of constructor args.  This change adds a test that exercises this
codepath in addition to the path for exported antlr libraries.

In the course of creating a testable PythonThriftBuilder, extract
BinaryUtil.Factory and ThriftBinary.Factory subsystems to both
encapsulate options and allow for directly constructable BinaryUtil and
ThriftBinary objects.

Some further file move cleanups are marked TODO in favor of keeping the
scope of this review from ballooning farther than it already has.

Testing Done:
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/72214777

Bugs closed: 1805, 1847

Reviewed at https://rbcommons.com/s/twitter/r/2511/

Coverage Stats

13576 of 20372 relevant lines covered (66.64%)

0.67 hits per line

pantsbuild / pants / 5762 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5762.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 5762 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5762.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 5762 / 3
0%
main: 93%

README BADGES
x