14
66%
master: 66%

Ran 12 Nov 2020 11:51PM UTC

Files 114

Run time 12s

Badge

Embed ▾

Committed 12 Nov 2020 11:36PM UTC coverage: 65.336% (+0.01%) from 65.324%

Job # TESTFLAGS="--coverage" CONTAINER="netaccess"

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Simplify sa.NewOrder transaction (#5177)

This change refactors the sa.NewOrder method to be more readable.
Previously, the outer method both modified and returned the request
object, a confusion violation of abstraction. Simultaneously, the inner
transaction function modified its input order object, but returned the
original request object which it hadn't modified.

Now, the NewOrder method does not modify its input, and instead
returns an all-new Order object. Additionally, the inner transaction
function does not modify its input, and returns an order model with
relevant fields set.

Part of #5166

Run Details

13292 of 20344 relevant lines covered (65.34%)

0.73 hits per line

letsencrypt / boulder / 13196 / 14
66%
master: 66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13196.14 (TESTFLAGS="--coverage" CONTAINER="netaccess")

letsencrypt / boulder / 13196 / 14 66% master: 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 13196.14 (TESTFLAGS="--coverage" CONTAINER="netaccess")

letsencrypt / boulder / 13196 / 14
66%
master: 66%

README BADGES
x