pantsbuild / pants / 36372 / 4
0%
main: 80%

LAST BUILD BRANCH: feature/remote-cache-logger
DEFAULT BRANCH: main
Ran
Files 415
Run time 27s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 0.0%. Remained the same
PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so MACOS_PYENV_PY27_VERSION=2.7.18 MACOS_PYENV_PY36_VERSION=3.6.10 MACOS_PYENV_PY37_VERSION=3.7.7 MACOS_PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py37.linux CACHE_NAME=python_tests.py37

cron

travis-ci-com

web-flow 
Improve error message for invalid unions in `Get()`s (#11102)

Before:

```
Engine traceback:
  in select
  in pants.core.goals.lint.lint
Traceback (no traceback):
  <pants native internals>
Exception: Type int is not a member of the LintRequest @union ("A union for StyleRequests that should be lintable.

    Subclass and install a member of this type to provide a linter.
    ")
```

After:

```
Engine traceback:
  in select
  in pants.core.goals.lint.lint
Traceback (no traceback):
  <pants native internals>
Exception: Invalid Get. Because the second argument to `Get(LintResults, LintRequest, 1)` is annotated with `@union`, the third argument should be a member of that union. Did you intend to register `UnionRule(LintRequest, int)`? If not, you may be using the wrong type (int) for the third argument.
```

This also drops the ability for union bases to customize the error message, which hasn't been used for some time. We are using unions very differently than a year ago. For example, we now usually introspect `UnionMembership` to proactively find all valid combinations. At least in our own code, a user should never hit a union error based on something they did, unless us developers had an issue in our code. So, we no longer need to worry about the message making sense to end users; we instead want it to make sense to plugin authors. This is the same logic, for example, for why our wording of the error message for `Get(Snapshot, Digest, 1)` is optimized for plugin authors. 

[ci skip-build-wheels]

0 of 29014 relevant lines covered (0.0%)

0.0 hits per line

Source Files on job 36372.4 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so MACOS_PYENV_PY27_VERSION=2.7.18 MACOS_PYENV_PY36_VERSION=3.6.10 MACOS_PYENV_PY37_VERSION=3.7.7 MACOS_PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py37.linux CACHE_NAME=python_tests.py37)