1
97%
master: 97%

Ran 06 Nov 2020 01:43PM UTC

Files 11

Run time 1s

Badge

Embed ▾

Committed 06 Nov 2020 01:36PM UTC coverage: 96.209% (+0.07%) from 96.135%

Job # 368.1

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Move solution stat collection into onSolutionSubmission (#144)

This PR moves the collection of solution specific details such as solver, objective value, utility, etc from the first `onTrade` handler to a specific `onSolutionSubmission` handler. Main motivation for this is that we want to record global stats such as fees, utility, volume and for that it's simpler to use a designated top level handler (it would be possible using todays setup but involve much more computation e.g. when deriving the utility of a certain traded). On the contrary, utility in OWL is part of the SolutionSubmission event already.

In this PR I'm mainly changing the status quo. In the next PR I will be adding a global Stat entity that also gets populated inside the onSolutionSubmission method.

It has the nice side effect that we no longer need to mock the call to `latestSolution` in our unit tests.

### Test Plan

CI

Run Details

406 of 422 relevant lines covered (96.21%)

7.86 hits per line

gnosis / dex-subgraph / 368 / 1
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 368.1

gnosis / dex-subgraph / 368 / 1 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 368.1

gnosis / dex-subgraph / 368 / 1
97%
master: 97%

README BADGES
x