368
97%

Ran 06 Nov 2020 01:43PM UTC

Jobs 1

Files 11

Run time 2s

Badge

Embed ▾

pending completion

Build # 368

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Move solution stat collection into onSolutionSubmission (#144)

This PR moves the collection of solution specific details such as solver, objective value, utility, etc from the first `onTrade` handler to a specific `onSolutionSubmission` handler. Main motivation for this is that we want to record global stats such as fees, utility, volume and for that it's simpler to use a designated top level handler (it would be possible using todays setup but involve much more computation e.g. when deriving the utility of a certain traded). On the contrary, utility in OWL is part of the SolutionSubmission event already.

In this PR I'm mainly changing the status quo. In the next PR I will be adding a global Stat entity that also gets populated inside the onSolutionSubmission method.

It has the nice side effect that we no longer need to mock the call to `latestSolution` in our unit tests.

### Test Plan

CI

Run Details

406 of 422 relevant lines covered (96.21%)

7.86 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	368.1	06 Nov 2020 01:43PM UTC	0	96.21	Travis Job 368.1

Source Files on build 368

Detailed source file information is not available for this build.

gnosis / dex-subgraph / 368
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 368

gnosis / dex-subgraph / 368 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 368

gnosis / dex-subgraph / 368
97%

README BADGES
x