gnosis / dex-services / 5395 / 3

31%

master: 31%

push

travis-pro

Use query hops param for price estimation (#1501)

This PR implements part of #1369 namely the integration of the hops Query parameter into the price estimation API (I couldn't reuse the other PR because the merge conflicts were too severe). It reuses the idea of creating a TokenPairRange type that can be passed along when both the pair and hops are important.

Unlike the other PR it continues to use the unbound price estimator in the services (instead of setting it to 30 hops). This is mainly for performance considerations and with the assumption that our orderbook in practice wouldn't use more than 30 hops anyways (we might eventually want to pick a realistic small number but this is beyond the scope of this PR).

This PR also leaves the test cases mostly untouched (using unbounded estimation wherever possible) as the actually bounding logic is covered by unit tests inside the bellman ford module.

I also stripped off the benchmarking code as this seems suitable for another PR.

### Test Plan
Unit tests + loading a local web and making sure we can see the impact of changing the hops parameter in the orderbook view.

14111 of 55985 branches covered (25.2%)

Branch coverage included in aggregate %.

3751 of 5848 relevant lines covered (64.14%)

40487.66 hits per line