gnosis / dex-services / 5390 / 3

31%

master: 31%

push

travis-pro

Version orderbook file (#1292)

This PR adds a new `version` field to the `EventRegistry` to ensure that the orderbook file is compatible between new driver and price-estimator versions. This is because the `bincode` serialization seems to only care about binary size and may conflate unrelated types as well as different fields as long as they:
- are the same size
- are in the same position

This new `Version` struct is a 0-sized serialization helper that ensure that the file matches the correct version when deserializing. This gives us some manual control when updating the orderbook file structure so we can ensure it doesn't incorrectly read an orderbook file in the old format.

### Test Plan

First check that a significant change to the orderbook type goes undetected:
```
$ cargo checkout master
$ cargo run -p price-estimator -- --orderbook-file target/orderbook.mainnet.bin --log-filter "error,core::orderbook=info"
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/price-estimator --orderbook-file target/orderbook.mainnet.bin --log-filter 'error,core::orderbook=info'`
2020-08-11T06:52:26.097Z INFO [core::orderbook::streamed::updating_orderbook] Updating event based orderbook with from block 0 to block 10637118.
2020-08-11T07:10:45.764Z INFO [core::orderbook::streamed::updating_orderbook] Received 215399 events.
2020-08-11T07:23:39.519Z INFO [core::orderbook::streamed::updating_orderbook] Finished applying events
^C
```

<details>
<summary>apply this patch:</summary>
<p>

```diff
diff --git a/core/src/history/events.rs b/core/src/history/events.rs
index 47433ed..661dfd0 100644
--- a/core/src/history/events.rs
+++ b/core/src/history/events.rs
@@ -23,13 +23,20 @@ use typenum::U1;
 // However, the orderbook state (`State`) cannot remove events. To support this, we keep an ordered
 // list of all events based on which the state is built.
 
-#[derive(Debug, Deserialize, Eq, Ord, Partial... (continued)

13751 of 55089 branches covered (24.96%)

Branch coverage included in aggregate %.

3727 of 5814 relevant lines covered (64.1%)

40718.34 hits per line