pantsbuild / pants / 36227 / 5
0%
main: 80%

LAST BUILD BRANCH: refactor_dep_inference
DEFAULT BRANCH: main
Ran
Files 418
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 0.0%. Remained the same
PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so MACOS_PYENV_PY27_VERSION=2.7.18 MACOS_PYENV_PY36_VERSION=3.6.10 MACOS_PYENV_PY37_VERSION=3.7.7 MACOS_PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux CACHE_NAME=python_tests.py36

push

travis-ci-com

web-flow 
Restore EngineAware metadata() method with non-cpython-reliant data structures (#11054)

### Problem

It was necessary to revert https://github.com/pantsbuild/pants/pull/11047 , which added a new EngineAware method `metadata()`, since this introduced a dependency on the `cpython` for the `workunit_store` crate, which caused problems in CI.

### Solution

This PR un-reverts the original commit, and modifies the data structures involved so that the `workunit_store` no longer needs to depend on `cpython`. Instead of `WorkunitMetadata` needing to store a (cpython-provided) `PyObject` object, it stores a bespoke `UserMetadataItem` data structure, which simply wraps a UUID. This type is now carried around on `WorkunitMetadata`, and indexes into a per-`Session` hash map storing a map from `UserMetadataItem` to `Value`, which we use when we create Python objects from Workunits. This way, only the engine crate needs to be aware of `cpython` types. 

Additionally, the `PartialEq`, `Eq`, and `Default` implementations for some of the workunit-related types proved no longer necessary, and were removed.

0 of 29178 relevant lines covered (0.0%)

0.0 hits per line

Source Files on job 36227.5 (PANTS_CONFIG_FILES="${TRAVIS_BUILD_DIR}/pants.travis-ci.toml" PANTS_DYNAMIC_UI=false LC_ALL="en_US.UTF-8" AWS_BUCKET=ci-public.pantsbuild.org BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so MACOS_PYENV_PY27_VERSION=2.7.18 MACOS_PYENV_PY36_VERSION=3.6.10 MACOS_PYENV_PY37_VERSION=3.7.7 MACOS_PYENV_PY38_VERSION=3.8.3 PYENV_ROOT_OSX=${HOME}/.pants_pyenv PYENV_ROOT="${PYENV_ROOT:-${PYENV_ROOT_OSX}}" PATH="${PYENV_ROOT}/shims:${PATH}" AWS_CLI_ROOT="${HOME}/.aws_cli" AWS_ACCESS_KEY_ID__TO_BE_REEXPORTED_ON_DEPLOYS=AKIAV6A6G7RQ2HFZ5KP7 AWS_SECRET_ACCESS_KEY=[secure] RUST_BACKTRACE="all" BOOTSTRAPPED_PEX_KEY_SUFFIX=py36.linux CACHE_NAME=python_tests.py36)