3
96%
master: 96%

Ran 27 Sep 2020 09:43PM UTC

Files 8

Run time 0s

Badge

Embed ▾

Committed 27 Sep 2020 09:41PM UTC coverage: 95.271%. Remained the same

Job # TEST_CMD="coverage run -m unittest"

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Repair colorama wrapping on non-Windows platforms (#1670)

* Repair colorama wrapping on non-Windows platforms

The wrap_stream_for_windows() function calls
colorama.initialise.wrap_stream() function to apply colorama's magic to
wrapper to the output stream. Except this wrapper is only applied on
Windows platforms that need it, otherwise the original stream is
returned as-is.

The colorama wrapped stream lacks a detach() method, so a no-op lambda
was being assigned to the wrapped stream.

The problem is that the no-op lambda was being assigned unconditionally
whether or not colorama actually returns a wrapped stream, thus
replacing the original TextIOWrapper's detach() method. Replacing the
detach() method with a no-op lambda is the root cause of the problem
observed in #1664.

The solution is to only assign the no-op detach() method if the stream
lacks its own detach() method.

Repairs #1664

Run Details

4815 of 5054 relevant lines covered (95.27%)

0.95 hits per line

psf / black / 1221 / 3
96%
master: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1221.3 (TEST_CMD="coverage run -m unittest")

psf / black / 1221 / 3 96% master: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1221.3 (TEST_CMD="coverage run -m unittest")

psf / black / 1221 / 3
96%
master: 96%

README BADGES
x