1221
96%

Ran 27 Sep 2020 09:42PM UTC

Jobs 5

Files 8

Run time 48s

Badge

Embed ▾

pending completion

Build # 1221

Build Type

push

travis-ci-com

Committed by

web-flow

Commit Message

Repair colorama wrapping on non-Windows platforms (#1670)

* Repair colorama wrapping on non-Windows platforms

The wrap_stream_for_windows() function calls
colorama.initialise.wrap_stream() function to apply colorama's magic to
wrapper to the output stream. Except this wrapper is only applied on
Windows platforms that need it, otherwise the original stream is
returned as-is.

The colorama wrapped stream lacks a detach() method, so a no-op lambda
was being assigned to the wrapped stream.

The problem is that the no-op lambda was being assigned unconditionally
whether or not colorama actually returns a wrapped stream, thus
replacing the original TextIOWrapper's detach() method. Replacing the
detach() method with a no-op lambda is the root cause of the problem
observed in #1664.

The solution is to only assign the no-op detach() method if the stream
lacks its own detach() method.

Repairs #1664

Run Details

4826 of 5053 relevant lines covered (95.51%)

3.81 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1221.1 (TEST_CMD="pre-commit run --all-files --show-diff-on-failure")	27 Sep 2020 09:42PM UTC	0.0	Travis Job 1221.1
2	1221.2 (TEST_CMD="coverage run -m unittest")	27 Sep 2020 09:43PM UTC	95.27	Travis Job 1221.2
3	1221.3 (TEST_CMD="coverage run -m unittest")	27 Sep 2020 09:43PM UTC	95.27	Travis Job 1221.3
4	1221.4 (TEST_CMD="coverage run -m unittest")	27 Sep 2020 09:43PM UTC	95.36	Travis Job 1221.4
5	1221.5 (TEST_CMD="coverage run -m unittest")	27 Sep 2020 09:43PM UTC	95.34	Travis Job 1221.5

Source Files on build 1221

Detailed source file information is not available for this build.

psf / black / 1221
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1221

psf / black / 1221 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1221

psf / black / 1221
96%

README BADGES
x