5
97%
master: 97%

Ran 20 Sep 2020 05:59PM UTC

Files 38

Run time 3s

Badge

Embed ▾

Committed 20 Sep 2020 05:55PM UTC coverage: 93.779%. Remained the same

Job # jruby-9.2, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true

Build Type

push

travis-ci

Committed by

hainesr

Commit Message

Correctly read extra fields when opening a zip file.

Previously, only the extra fields stored in the central directory were
being read in. In reality it is often the case that the extra field in
the central directory is just a marker, and the full data is in the
local header. So we need to read both in and merge the two into the
final correct extra field. This merging infrastructure was already
implemented in the extra field code but we never actually read the
local extra fields in until now.

Reading the central directory headers and local entry headers seems
rather fragile, so we can't just read one over the other and hope to end
up with a correctly merged set of extra fields because this breaks other
things. So we need to specifically read the local extra field data and
merge just those bits.

This commit also fixes a couple of tests that were 'broken' by us now
reading extra fields in correctly!

Run Details

1990 of 2122 relevant lines covered (93.78%)

551.86 hits per line

hainesr / rubyzip / 238 / 5
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 238.5 (jruby-9.2, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)

hainesr / rubyzip / 238 / 5 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 238.5 (jruby-9.2, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)

hainesr / rubyzip / 238 / 5
97%
master: 97%

README BADGES
x