238
97%
master: 97%

Ran 20 Sep 2020 05:56PM UTC

Jobs 10

Files 38

Run time 5min

Badge

Embed ▾

pending completion

Build # 238

Build Type

push

travis-ci

Committed by

hainesr

Commit Message

Correctly read extra fields when opening a zip file.

Previously, only the extra fields stored in the central directory were
being read in. In reality it is often the case that the extra field in
the central directory is just a marker, and the full data is in the
local header. So we need to read both in and merge the two into the
final correct extra field. This merging infrastructure was already
implemented in the extra field code but we never actually read the
local extra fields in until now.

Reading the central directory headers and local entry headers seems
rather fragile, so we can't just read one over the other and hope to end
up with a correctly merged set of extra fields because this breaks other
things. So we need to specifically read the local extra field data and
merge just those bits.

This commit also fixes a couple of tests that were 'broken' by us now
reading extra fields in correctly!

Run Details

1905 of 1986 relevant lines covered (95.92%)

5885.57 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	238.1 (2.4, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 05:56PM UTC	95.82	Travis Job 238.1
2	238.2 (2.5, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 05:56PM UTC	95.82	Travis Job 238.2
3	238.3 (2.6, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 05:56PM UTC	95.8	Travis Job 238.3
4	238.4 (2.7, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 05:56PM UTC	95.8	Travis Job 238.4
5	238.5 (jruby-9.2, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 05:59PM UTC	93.78	Travis Job 238.5
6	238.6 (jruby-9.2, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 06:01PM UTC	93.78	Travis Job 238.6
8	238.8 (ruby-head, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 05:58PM UTC	95.8	Travis Job 238.8
9	238.9 (truffleruby-head, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 06:00PM UTC	94.41	Travis Job 238.9
10	238.10 (truffleruby, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 06:01PM UTC	94.41	Travis Job 238.10
11	238.11 (jruby-head, JRUBY_OPTS="--debug" COVERALLS_PARALLEL=true)	20 Sep 2020 06:03PM UTC	93.73	Travis Job 238.11

Source Files on build 238

Detailed source file information is not available for this build.

hainesr / rubyzip / 238
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 238

hainesr / rubyzip / 238 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 238

hainesr / rubyzip / 238
97%
master: 97%

README BADGES
x