2
86%
main: 83%

Ran 14 Aug 2020 05:44PM UTC

Files 36

Run time 18s

Badge

Embed ▾

Committed 14 Aug 2020 05:44PM UTC coverage: 88.192% (-0.01%) from 88.205%

Job # GO111MODULE=off

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Inhibit Go's default TCP keepalive settings for NATS (#1562)

Inhibit Go's default TCP keepalive settings for NATS

Go 1.13 changed the semantics of the tuning parameters for TCP keepalives, including the default value.  This affects all TCP listeners.  The NATS protocol has its own L7 keepalive system (PING/PONG) and the Go defaults are not a good fit for some valid deployment scenarios, while Go doesn't directly expose a working API for tuning these.

Rather than add a configuration knob and pull in another dependency (with portability issues) just disable TCP keepalives for all listeners used for speaking the NATS protocol.

Change the tests so we test the same logic.  Do not change HTTP monitoring, profiling, or the websocket API listeners.

Change KeepAlive on client connections too.

Coverage Stats

26574 of 30132 relevant lines covered (88.19%)

82117.89 hits per line

nats-io / nats-server / 6061 / 2
86%
main: 83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6061.2 (GO111MODULE=off)

nats-io / nats-server / 6061 / 2 86% main: 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6061.2 (GO111MODULE=off)

nats-io / nats-server / 6061 / 2
86%
main: 83%

README BADGES
x