• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

SAP / fundamental-ngx / 10659 / 1
79%
master: 79%

Build:
DEFAULT BRANCH: master
Ran 07 Aug 2020 02:48PM UTC
Files 419
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

07 Aug 2020 02:41PM UTC coverage: 79.136%. Remained the same
10659.1

push

travis-ci

web-flow
fix: (platform) Bug fix for multiple menu triggers with same menu (#2722)

* fix: (platform) Bug fix for multiple menu triggers with same menu

For a scenario where a single menu is referenced by multiple trigger via
the `menuTriggerFor` directive, there is a bug when clicking from one
button to the next. Clicking on the first button will open the menu.
Clicking on the second button will then close the menu, without opening
it again and attaching to second trigger element. This happens because
the close menu event from an "outside" click is resolved after the open
menu call from the second button click, so the menu does not open the
second time.

I added a `setTimeout` delay on the open menu call to insure it happens
after the close menu is resolved.

Fixing unit tests after adding delay to openMenu

CSS style fixes

Adding "tabindex" to fdp-button host element

Removing blue focus outline on button

Adding return types and typedocs

Fixing lint issue.

* Fixing menu-item styles.

Co-authored-by: deno <mladen.droshev@sap.com>
Co-authored-by: Inna Atanasova <39598672+InnaAtanasova@users.noreply.github.com>

1824 of 2802 branches covered (65.1%)

Branch coverage included in aggregate %.

5944 of 7014 relevant lines covered (84.74%)

99.68 hits per line

Source Files on job 10659.1
  • Tree
  • List 0
  • Changed 11
  • Source Changed 0
  • Coverage Changed 11
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 8125
  • Travis Job 10659.1
  • 0e57ce89 on github
  • Prev Job for on master (#10639.1)
  • Next Job for on master (#10668.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc