SAP / fundamental-ngx / 10659

79%

push

travis-ci

fix: (platform) Bug fix for multiple menu triggers with same menu (#2722)

* fix: (platform) Bug fix for multiple menu triggers with same menu

For a scenario where a single menu is referenced by multiple trigger via
the `menuTriggerFor` directive, there is a bug when clicking from one
button to the next. Clicking on the first button will open the menu.
Clicking on the second button will then close the menu, without opening
it again and attaching to second trigger element. This happens because
the close menu event from an "outside" click is resolved after the open
menu call from the second button click, so the menu does not open the
second time.

I added a `setTimeout` delay on the open menu call to insure it happens
after the close menu is resolved.

Fixing unit tests after adding delay to openMenu

CSS style fixes

Adding "tabindex" to fdp-button host element

Removing blue focus outline on button

Adding return types and typedocs

Fixing lint issue.

* Fixing menu-item styles.

Co-authored-by: deno <mladen.droshev@sap.com>
Co-authored-by: Inna Atanasova <39598672+InnaAtanasova@users.noreply.github.com>

1824 of 2802 branches covered (65.1%)

Branch coverage included in aggregate %.

5944 of 7014 relevant lines covered (84.74%)

99.68 hits per line