2
96%
master: 96%

Ran 27 Jul 2020 07:10AM UTC

Files 15

Run time 2s

Badge

Embed ▾

Committed 27 Jul 2020 07:09AM UTC coverage: 95.829%. Remained the same

Job # 317.2

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Change factory methods to class methods (#103)

Instead of declaring the create_from_request_pdu and create_from_response_pdu factory methods as @staticmethod, use @classmethod. Then the class is passed to the method as the cls parameter, which can be used to instantiate an instance, rather than hardcoding the class name.

This allows the function classes to be subclassed without having to reimplement the factory methods just to change the class name.

Also fixes up some comments that were incorrect.

Run Details

850 of 887 relevant lines covered (95.83%)

0.96 hits per line

AdvancedClimateSystems / uModbus / 317 / 2
96%
master: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 317.2

AdvancedClimateSystems / uModbus / 317 / 2 96% master: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 317.2

AdvancedClimateSystems / uModbus / 317 / 2
96%
master: 96%

README BADGES
x