317
96%

Ran 27 Jul 2020 07:10AM UTC

Jobs 6

Files 15

Run time 51s

Badge

Embed ▾

pending completion

Build # 317

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Change factory methods to class methods (#103)

Instead of declaring the create_from_request_pdu and create_from_response_pdu factory methods as @staticmethod, use @classmethod. Then the class is passed to the method as the cls parameter, which can be used to instantiate an instance, rather than hardcoding the class name.

This allows the function classes to be subclassed without having to reimplement the factory methods just to change the class name.

Also fixes up some comments that were incorrect.

Run Details

849 of 886 relevant lines covered (95.82%)

5.75 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	317.1	27 Jul 2020 07:10AM UTC	96.08	Travis Job 317.1
2	317.2	27 Jul 2020 07:10AM UTC	95.83	Travis Job 317.2
3	317.3	27 Jul 2020 07:10AM UTC	95.83	Travis Job 317.3
4	317.4	27 Jul 2020 07:10AM UTC	95.83	Travis Job 317.4
5	317.5	27 Jul 2020 07:10AM UTC	95.83	Travis Job 317.5
6	317.6	27 Jul 2020 07:11AM UTC	96.05	Travis Job 317.6

AdvancedClimateSystems / uModbus / 317
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 317

AdvancedClimateSystems / uModbus / 317 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 317

AdvancedClimateSystems / uModbus / 317
96%

README BADGES
x