3
0%
main: 93%

Ran 10 Jun 2015 10:37PM UTC

Files 330

Run time 16s

Badge

Embed ▾

Committed 10 Jun 2015 09:22PM UTC coverage: 65.98%. Remained the same

Job # CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'"

Build Type

push

travis-ci

Committed by

areitz

Commit Message

Add a coherent error message when scrooge has no sources.

I wasted way too much time trying to understand this error message:
./pants test geoduck/service/src/main/thrift:thrift-java
...
Exception message: [Errno 2] No such file or directory: u'/Users/thowland/workspace/source/birdcage/.pants.d/gen/scrooge/java-finagle/gen-file-map-by-target/geoduck.service.src.main.thrift.thrift-java'

What pants is trying to say is: the given target has no sources.

With this change we get the more useful message:

Exception message: Invalid target JavaThriftLibrary(BuildFileAddress(FilesystemBuildFile(/Users/thowland/workspace/source/birdcage/factorbird/factorbird-thrift-only/src/main/thrift/BUILD), thrift-scala)): no thrift files found

Testing Done:
https://github.com/pantsbuild/pants/pull/1660
https://travis-ci.org/pantsbuild/pants/builds/66227433

Reviewed at https://rbcommons.com/s/twitter/r/2329/

Coverage Stats

13097 of 19850 relevant lines covered (65.98%)

0.66 hits per line

pantsbuild / pants / 5256 / 3
0%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5256.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 5256 / 3 0% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5256.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'")

pantsbuild / pants / 5256 / 3
0%
main: 93%

README BADGES
x