5
93%
master: 93%

Ran 28 Jun 2020 11:36AM UTC

Files 37

Run time 3s

Badge

Embed ▾

Committed 28 Jun 2020 11:34AM UTC coverage: 92.479% (+0.008%) from 92.471%

Job # 2.6.3, ADAPTER=active_record, gemfiles/activerecord_4.gemfile

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Support strict with_role queries. Issue #362 (#543)

* Support strict with_role queries

Why:

* There is an outstanding issues #362
* strict mode should be enforced on role queries and resource queries

How:

* Pass a strict flag to the scope function
* call where or where_strict depending on strict flag in active_record adapter
* Add tests for strict mode resource queries

Note:

* This PR does not address strict mode for mongoid since I am unfamiliar with that ORM

* Update where_strict for mongoid

Why:

* The tests will fail until mongo works with strict resource querying

This change addresses the need by:

* Copy the where_strict implementation from the active record adapter

* Make sure to call strict where

* Refactor to reduce mutations

Co-authored-by: Thomas McDonald <thomas-mcdonald@users.noreply.github.com>

Run Details

1623 of 1755 relevant lines covered (92.48%)

50.08 hits per line

RolifyCommunity / rolify / 804 / 5
93%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 804.5 (2.6.3, ADAPTER=active_record, gemfiles/activerecord_4.gemfile)

RolifyCommunity / rolify / 804 / 5 93% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 804.5 (2.6.3, ADAPTER=active_record, gemfiles/activerecord_4.gemfile)

RolifyCommunity / rolify / 804 / 5
93%
master: 93%

README BADGES
x