RolifyCommunity / rolify / 804

93%

push

travis-ci

Support strict with_role queries. Issue #362 (#543)

* Support strict with_role queries

Why:

* There is an outstanding issues #362
* strict mode should be enforced on role queries and resource queries

How:

* Pass a strict flag to the scope function
* call where or where_strict depending on strict flag in active_record adapter
* Add tests for strict mode resource queries

Note:

* This PR does not address strict mode for mongoid since I am unfamiliar with that ORM

* Update where_strict for mongoid

Why:

* The tests will fail until mongo works with strict resource querying

This change addresses the need by:

* Copy the where_strict implementation from the active record adapter

* Make sure to call strict where

* Refactor to reduce mutations

Co-authored-by: Thomas McDonald <thomas-mcdonald@users.noreply.github.com>

63 of 63 new or added lines in 4 files covered. (100.0%)

1783 of 1911 relevant lines covered (93.3%)

845.27 hits per line