1
50%
master: 50%

Ran 23 Jun 2020 07:59PM UTC

Files 613

Run time 3min

Badge

Embed ▾

Committed 23 Jun 2020 07:54PM UTC coverage: 46.82% (+0.5%) from 46.293%

Job # CODACY_PROJECT_TOKEN=[secure]

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Better error handling for reconciliation process - fixes #2590 (#2671)

* Harden reconciliation - Fixes #2590

- check for non-JSON / unparseable JSON returns
- handle malformed results response with no name for candidates
- catch any Exception, not just IOExceptions
- call processManager.onFailedProcess() for cleanup on error

* Add default constructor for Jackson

Jackson complains about needing a default constructor for the
NON_DEFAULT annotation, but I'm not sure why this worked before.

* Clean up indentation and unused variable - no functional changes

Make indentation consistent throughout the module, changing recently
added lines to use the standard all spaces convention.

Remove unused count variable

* Simplify control flow

* Update limit parameter comment. No functional change.

* Replace ternary expression which is causing NPE

* Add reconciliation tests using mock HTTP server

Coverage Stats

11660 of 24904 relevant lines covered (46.82%)

0.47 hits per line

OpenRefine / OpenRefine / 3834 / 1
50%
master: 50%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3834.1 (CODACY_PROJECT_TOKEN=[secure])

OpenRefine / OpenRefine / 3834 / 1 50% master: 50%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3834.1 (CODACY_PROJECT_TOKEN=[secure])

OpenRefine / OpenRefine / 3834 / 1
50%
master: 50%

README BADGES
x