3834
50%

Ran 23 Jun 2020 07:59PM UTC

Jobs 4

Files 613

Run time 5min

Badge

Embed ▾

pending completion

Build # 3834

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Better error handling for reconciliation process - fixes #2590 (#2671)

* Harden reconciliation - Fixes #2590

- check for non-JSON / unparseable JSON returns
- handle malformed results response with no name for candidates
- catch any Exception, not just IOExceptions
- call processManager.onFailedProcess() for cleanup on error

* Add default constructor for Jackson

Jackson complains about needing a default constructor for the
NON_DEFAULT annotation, but I'm not sure why this worked before.

* Clean up indentation and unused variable - no functional changes

Make indentation consistent throughout the module, changing recently
added lines to use the standard all spaces convention.

Remove unused count variable

* Simplify control flow

* Update limit parameter comment. No functional change.

* Replace ternary expression which is causing NPE

* Add reconciliation tests using mock HTTP server

Coverage Stats

11661 of 24903 relevant lines covered (46.83%)

1.87 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3834.1 (CODACY_PROJECT_TOKEN=[secure])	23 Jun 2020 07:59PM UTC	46.82	Travis Job 3834.1
2	3834.2 (CODACY_PROJECT_TOKEN=[secure])	23 Jun 2020 08:00PM UTC	46.81	Travis Job 3834.2
3	3834.3 (CODACY_PROJECT_TOKEN=[secure])	23 Jun 2020 07:59PM UTC	46.81	Travis Job 3834.3
4	3834.4 (CODACY_PROJECT_TOKEN=[secure])	23 Jun 2020 07:59PM UTC	46.81	Travis Job 3834.4

Source Files on build 3834

Detailed source file information is not available for this build.

OpenRefine / OpenRefine / 3834
50%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3834

OpenRefine / OpenRefine / 3834 50%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3834

OpenRefine / OpenRefine / 3834
50%

README BADGES
x