3
98%
master: 98%

Ran 23 Jun 2020 12:55PM UTC

Files 17

Run time 32s

Badge

Embed ▾

Committed 23 Jun 2020 12:48PM UTC coverage: 96.913% (+4.6%) from 92.287%

Job # 1104.3

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Reject non-numerical arrays as arguments to conv (#360)

* Reject non-numerical arrays as arguments to conv

Currently `conv` has a method `conv(::AbstractArray, ::AbstractArray)`
that is intended to cast arrays of different ndims into
dimension-compatible ones before delegating to more detailed methods.
Unfortunately, this method ends up catching arrays with non-`Number`
eltypes, and since no detailed methods accept such arrays as arguments,
this method ends up calling itself and results in stack overflow.  This
commit fixes that by restricting the signature of the abovementioned
method to `conv(::AbstractArray{<:Number, N}, ::AbstractArray{<:Number,
P}) where {N, P}` so that calling `conv` with non-numerical arrays
is now a type error.

* Minor changes to conv

github.com/JuliaDSP/DSP.jl/pull/360#discussion_r426196101

Signed-off-by: Fred Miller <fghzxm@outlook.com>

* Add type assertions for conv

github.com/JuliaDSP/DSP.jl/pull/360#discussion_r427233595

Signed-off-by: Fred Miller <fghzxm@outlook.com>

Coverage Stats

1978 of 2041 relevant lines covered (96.91%)

310156.91 hits per line

JuliaDSP / DSP.jl / 1104 / 3
98%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1104.3

JuliaDSP / DSP.jl / 1104 / 3 98% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1104.3

JuliaDSP / DSP.jl / 1104 / 3
98%
master: 98%

README BADGES
x