JuliaDSP / DSP.jl / 1104

98%

push

travis-ci

Reject non-numerical arrays as arguments to conv (#360)

* Reject non-numerical arrays as arguments to conv

Currently `conv` has a method `conv(::AbstractArray, ::AbstractArray)`
that is intended to cast arrays of different ndims into
dimension-compatible ones before delegating to more detailed methods.
Unfortunately, this method ends up catching arrays with non-`Number`
eltypes, and since no detailed methods accept such arrays as arguments,
this method ends up calling itself and results in stack overflow.  This
commit fixes that by restricting the signature of the abovementioned
method to `conv(::AbstractArray{<:Number, N}, ::AbstractArray{<:Number,
P}) where {N, P}` so that calling `conv` with non-numerical arrays
is now a type error.

* Minor changes to conv

github.com/JuliaDSP/DSP.jl/pull/360#discussion_r426196101

Signed-off-by: Fred Miller <fghzxm@outlook.com>

* Add type assertions for conv

github.com/JuliaDSP/DSP.jl/pull/360#discussion_r427233595

Signed-off-by: Fred Miller <fghzxm@outlook.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

1423 of 1474 relevant lines covered (96.54%)

2187808.8 hits per line