1
71%
master: 71%

Ran 09 May 2020 11:37AM CUT

Files 97

Run time 6s

Badge

Embed ▾

Committed 09 May 2020 11:35AM CUT coverage: 71.479% (+0.03%) from 71.447%

Job # 1519.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat(pkce): add EnforcePKCEForPublicClients config flag (#431)

Alternative proposal for the issue discussed in #389 and #391, where enforcement of PKCE is wanted only for certain clients.

Add a new flag EnforcePKCEForPublicClients which enforces PKCE only for public clients. The error hint is slightly different, as it mentions PKCE is enforced for "this client" rather than "clients". (It intentionally does not mention why it's enforced, as I think basing it on public clients is an implementation detail that servers may want to change without adding to the error hints).

Closes #389
Closes #391

Run Details

3847 of 5382 relevant lines covered (71.48%)

71.41 hits per line

Source Files on job 1519.1

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	internal/oauth2_explicit_storage.go	96	41	0	41	0.0
0.0	internal/authorize_code_strategy.go	82	40	0	40	0.0
0.0	internal/request.go	275	172	0	172	0.0
0.0	internal/oauth2_refresh_storage.go	96	41	0	41	0.0
0.0	internal/client.go	149	88	0	88	0.0
0.0	internal/authorize_code_storage.go	81	39	0	39	0.0
0.0	internal/pkce_storage_strategy.go	81	39	0	39	0.0
28.7	internal/authorize_request.go	357	230	66	164	12.0
36.54	internal/oauth2_strategy.go	170	104	38	66	3.0
37.36	internal/access_request.go	289	182	68	114	4.0

94.9
compose/
84.15
handler/
42.27
internal/
92.27
storage/
85.12
token/

ory / fosite / 1519 / 1
71%
master: 71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1519.1

ory / fosite / 1519 / 1 71% master: 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1519.1

ory / fosite / 1519 / 1
71%
master: 71%

README BADGES
x