1533
71%

Ran 23 May 2020 02:34PM UTC

Jobs 1

Files 97

Run time 8s

Badge

Embed ▾

Committed 23 May 2020 02:32PM UTC coverage: 71.543% (+0.03%) from 71.513%

Build # 1533

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix: double-decoding of client credentials in request body (#434)

I noticed that client credentials are URL-decoded after being extracted from the POST body form, which was already URL-decoded by Go. The accompanying error message suggests this was copied and pasted from the HTTP basic authorization header handling, which is the only place where the extra URL-decoding was needed (as per the OAuth 2.0 spec). The result is that client credentials containing %-prefixed sequences, whether valid sequences or not, are going to fail validation.

Remove the extra URL decoding. Add tests that ensure client credentials work with special characters in both the HTTP basic auth header and in the request body.

Run Details

3849 of 5380 relevant lines covered (71.54%)

71.39 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1533.1	23 May 2020 02:34PM UTC	0	71.54	Travis Job 1533.1

Source Files on build 1533

Detailed source file information is not available for this build.

ory / fosite / 1533
71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1533

ory / fosite / 1533 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1533

ory / fosite / 1533
71%

README BADGES
x