• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ICRAR / ngas / 411 / 1
69%
master: 69%

Build:
DEFAULT BRANCH: master
Ran 13 Feb 2020 08:39AM UTC
Files 163
Run time 13s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

13 Feb 2020 08:27AM UTC coverage: 68.2% (-0.006%) from 68.206%
DB=sqlite3

push

travis-ci

rtobar
Remove imp-based locking

In python 3.8 we are now actually getting warnings due to the imp module
getting eventually removed. We new its usage was discouraged, but now we
are really being told in the face we should stop using it.

It turns out this was actually a symptom that we were not doing things
right the begin with: importlib.import_module already checks for
sys.modules as a shortcut, and while it was possible for us to do this
check this separately in a safe manner using the imp module, it's not
possible to do safely without imp; the proper way of doing this then is
*always* calling import_module. This actually greatly simplifies the
code, and makes it stronger against multi-threading race conditions in
python 3.3+.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

13256 of 19437 relevant lines covered (68.2%)

0.68 hits per line

Source Files on job 411.1 (DB=sqlite3)
  • Tree
  • List 0
  • Changed 2
  • Source Changed 2
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 360
  • Travis Job 411.1
  • 7a32fa36 on github
  • Prev Job for DB=sqlite3 on master (#406.1)
  • Next Job for DB=sqlite3 on master (#414.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc