• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ICRAR / ngas / 411
69%

Build:
DEFAULT BRANCH: master
Ran 13 Feb 2020 08:39AM UTC
Jobs 7
Files 163
Run time 11min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
411

push

travis-ci

rtobar
Remove imp-based locking

In python 3.8 we are now actually getting warnings due to the imp module
getting eventually removed. We new its usage was discouraged, but now we
are really being told in the face we should stop using it.

It turns out this was actually a symptom that we were not doing things
right the begin with: importlib.import_module already checks for
sys.modules as a shortcut, and while it was possible for us to do this
check this separately in a safe manner using the imp module, it's not
possible to do safely without imp; the proper way of doing this then is
*always* calling import_module. This actually greatly simplifies the
code, and makes it stronger against multi-threading race conditions in
python 3.3+.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

13 of 13 new or added lines in 1 file covered. (100.0%)

13308 of 19433 relevant lines covered (68.48%)

4.78 hits per line

Jobs
ID Job ID Ran Files Coverage
1 411.1 (DB=sqlite3) 13 Feb 2020 08:39AM UTC 0
68.2
Travis Job 411.1
2 411.2 (DB=mysql) 13 Feb 2020 08:39AM UTC 0
68.28
Travis Job 411.2
3 411.3 (DB=postgresql) 13 Feb 2020 08:40AM UTC 0
68.24
Travis Job 411.3
4 411.4 13 Feb 2020 08:49AM UTC 0
68.23
Travis Job 411.4
5 411.5 13 Feb 2020 08:39AM UTC 0
68.24
Travis Job 411.5
6 411.6 13 Feb 2020 08:50AM UTC 0
68.32
Travis Job 411.6
7 411.7 13 Feb 2020 08:49AM UTC 0
68.29
Travis Job 411.7
Source Files on build 411
  • Tree
  • List 0
  • Changed 28
  • Source Changed 2
  • Coverage Changed 28
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Travis Build #411
  • 7a32fa36 on github
  • Prev Build on master (#406)
  • Next Build on master (#414)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc