pantsbuild / pants / 4779 / 3
0%
main: 93%

LAST BUILD BRANCH: fix/immutable-inputs-revalidation
DEFAULT BRANCH: main
Ran
Files 325
Run time 17s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 69.187% (+0.008%) from 69.179%
CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'"

push

travis-ci

fkorotkov 
local publish of zinc bootstraps

Notice we've changed how pants generates poms.

zinc uses the sbt incremental compiler. During the bootstrap process, it links with the source jar of the incremental compiler. This requires that when we generate our pom, we mark the dependency with <classifier>sources</classifier>. Interestingly, there is no binary artifact distributed for the incremental compiler. Just source.

The way this works in ivy is we have clauses like
```xml

    <dependency org="com.typesafe.sbt" name="compiler-interface" rev="0.13.7">
      <conf name="default" mapped="default"/>
      <artifact name="compiler-interface" type="jar" m:classifier="sources"/>
    </dependency>
```
The ivy task "makepom" works perfectly with this. We've modified pants so that we will also generate the correct maven dependency:
```xml
    <dependency>
      <groupId>com.typesafe.sbt</groupId>
      <artifactId>compiler-interface</artifactId>
      <version>0.13.7</version>
      <scope>compile</scope>
      <classifier>sources</classifier>
    </dependency>
```
I checked the maven documentation -- classifier is not very well documented. They write that it can "contain an arbitrary string". The xsd says:

    The classifier of the dependency. This allows distinguishing two artifacts that belong to the same POM but were built differently, and is appended to the filename after the version. For example, <code>jdk14</code> and <code>jdk15</code>.

Testing Done:
./pants publish.jar --no-dryrun --local=~/.m2/repository --no-local-snapshot --force --override=org.pantsbuild#zinc=1.0.0 zinc:bin

update all zinc references

./pants publish.jar --no-dryrun --local=~/.m2/repository --no-local-snapshot --force --override=org.pantsbuild#zinc=1.0.1 zinc:bin

works!

Reviewed at https://rbcommons.com/s/twitter/r/2168/

13306 of 19232 relevant lines covered (69.19%)

0.69 hits per line

Source Files on job 4779.3 (CI_FLAGS="-fkmsrcnet 'Unit tests for pants and pants-plugins'")