2
56%
develop: 56%

Ran 08 Feb 2020 09:12AM UTC

Files 880

Run time 1min

Badge

Embed ▾

Committed 08 Feb 2020 09:06AM UTC coverage: 52.231% (+0.002%) from 52.229%

Job # DB=postgres TYPE=server

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix (S3-Backup-Setting): ensure recipients and sender are corre… (#9417)

* fix: sender is not set to current user

I am not sure if I did it right:
1. import frappe
2. check if the sender is None: using frappe.session.user to fetch email address for current user

* fix: update the correct field name for S3-backup-setting

The field variable name should be updated to 'notify_email' instead of 'notification_email'.

* style: remove a trailing whitespace

* fix: Assign notify_email instead of calling frappe.db.get_value twice

* chore: remove default sender and notify_email check

* default sender already gets set in queue.py, so there's no need for a
  check inside __init__.py

* notify_email seems to be a mandatory field, so there's no need to
  check if the field has a value (assuming that it always will).

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>

Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>

Run Details

22314 of 42722 relevant lines covered (52.23%)

0.52 hits per line

frappe / frappe / 28068 / 2
56%
develop: 56%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 28068.2 (DB=postgres TYPE=server)

frappe / frappe / 28068 / 2 56% develop: 56%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 28068.2 (DB=postgres TYPE=server)

frappe / frappe / 28068 / 2
56%
develop: 56%

README BADGES
x