28068
56%

Ran 08 Feb 2020 09:12AM UTC

Jobs 4

Files 880

Run time 1288min

Badge

Embed ▾

pending completion

Build # 28068

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix (S3-Backup-Setting): ensure recipients and sender are corre… (#9417)

* fix: sender is not set to current user

I am not sure if I did it right:
1. import frappe
2. check if the sender is None: using frappe.session.user to fetch email address for current user

* fix: update the correct field name for S3-backup-setting

The field variable name should be updated to 'notify_email' instead of 'notification_email'.

* style: remove a trailing whitespace

* fix: Assign notify_email instead of calling frappe.db.get_value twice

* chore: remove default sender and notify_email check

* default sender already gets set in queue.py, so there's no need for a
  check inside __init__.py

* notify_email seems to be a mandatory field, so there's no need to
  check if the field has a value (assuming that it always will).

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>

Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>

Run Details

22511 of 42722 relevant lines covered (52.69%)

1.57 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	28068.1 (DB=mariadb TYPE=server)	08 Feb 2020 09:13AM UTC	52.24	Travis Job 28068.1
2	28068.2 (DB=postgres TYPE=server)	08 Feb 2020 09:12AM UTC	52.23	Travis Job 28068.2
3	28068.3 (DB=mariadb TYPE=ui)	09 Feb 2020 06:40AM UTC		Travis Job 28068.3
4	28068.4 (DB=mariadb TYPE=server)	08 Feb 2020 09:13AM UTC	52.22	Travis Job 28068.4

Source Files on build 28068

Detailed source file information is not available for this build.

frappe / frappe / 28068
56%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 28068

frappe / frappe / 28068 56%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 28068

frappe / frappe / 28068
56%

README BADGES
x