1
89%
master: 89%

Ran 23 Jan 2020 01:15AM UTC

Files 271

Run time 22s

Badge

Embed ▾

Committed 23 Jan 2020 01:05AM UTC coverage: 87.376% (+0.006%) from 87.37%

Job # 16955.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

xds: refactor LookasideLb for EDS-only usecase and integrate load stats report

- Replace XdsComms2 with XdsClientImpl
- Enable/Disable load report stats with `XdsClient` APIs.

Testing strategy:
- Use real XdsClientImp for EDS-only because the balancer creates the XdsClient by itself. The state of the XdsClientImpl will be the actual state as real.
- Use mock XdsClient for non EDS-only case because the XdsClient in resolved addresses attributes is supposed to be a stateful XdsClient with some pre-existing CDS state, so creating a brand new real XdsClientImp in test can not simulate the same state. In this case only verify interaction with XdsClient APIs.
- Use a `LocalityStoreFactory` to verify interaction with `LocalityStore` APIs. However, this can not cover any interaction with the `Helper` and `LoadStatsStore` inputs of `LocalityStoreFactory.newLocalityStore(Helper, LoadBalancerRegistry, LoadStatsStore)`, so some basic non-exhaustive tests are added to cover the gap.

The testing strategy is imperfect but is a trade-off considering load stats report is very hard to test here and LocalityStore/real balancing behavior is too much to be exhaustively tested in `LookasideLb`.

Run Details

16127 of 18457 relevant lines covered (87.38%)

0.87 hits per line

grpc / grpc-java / 16955 / 1
89%
master: 89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 16955.1

grpc / grpc-java / 16955 / 1 89% master: 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 16955.1

grpc / grpc-java / 16955 / 1
89%
master: 89%

README BADGES
x