pantsbuild
/
pants
/
4545
/
3
0%
main: 93%
main: 93%
|
Ran
|
Files
322
|
Run time
17s
|
Badge
Embed ▾
README BADGES
|
coverage: 69.277% (+0.05%) from 69.227%
push
travis-ci
ericzundelAdds the ability to specify explicit fields in MANIFEST.MF in a jvm_binary target. - Added 'manifest_entries' to jvm_binary target - Added a query to see if the manifest is empty in Manifest - Support detecting the git workdir from a directory other than cwd - Allow setting of both a main entry point and a custom manifest file when invoking jar-tool - Special 'git' value for Implementation-Version pulls the current git commit id for the directory where the jvm_binary() target is defined. Testing Done: Updated tests. Modified the `hello/simple/BUILD` file ``` jvm_binary(name = 'simple', source = 'HelloWorld.java', - main = 'org.pantsbuild.example.hello.simple.HelloWorld', + #main = 'org.pantsbuild.example.hello.simple.HelloWorld', + manifest_entries = { + 'Main-Class' : 'org.pantsbuild.example.hello.simple.HelloWorld', + 'Foo' : 'foo', + 'Implementation-Version' : 'git', + } ) ``` Then ran `./pants binary examples/src/java/org/pantsbuild/example/hello/simple/` and inspected the MANIFEST.MF file: ``` Manifest-Version: 1.0 Implementation-Version: 748d4daed Foo: foo Created-By: com.twitter.common.jar.tool.JarBuilder Main-Class: org.pantsbuild.example.hello.simple.HelloWorld ``` Bugs closed: 1402 Reviewed at https://rbcommons.com/s/twitter/r/2084/
13074 of 18872 relevant lines covered (69.28%)
0.69 hits per line
