1
97%
master: 97%

Ran 07 Nov 2019 10:19PM UTC

Files 99

Run time 7s

Badge

Embed ▾

Committed 07 Nov 2019 10:18PM UTC coverage: 96.287% (+0.06%) from 96.224%

Job # 2.3

Build Type

push

travis-ci

Committed by

brandur-stripe

Commit Message

Add simple instrumentation callback (#870)

* Add simple instrumentation callback

We used to insert Faraday::Request::Instrumentation into our Faraday middleware
stack to be able to instrument Stripe calls with StatsD. With Faraday being
removed in version 5, this required some rework. This commit implements a simple
callback system that can be used with any kind of instrumentation system.

* Add a topic to Stripe::Instrumentation notifications

... and a :request topic to subscribe to

* Use a RequestEvent value object instead of positional args in callback

This way the RequestLogContext object doesn't get exposed externally. Since the
same value object can be received by multiple subscribers it is frozen to
prevent accidental mutations across threads.

* Relocate tests for instrumentation and add more tests

Run Details

1997 of 2074 relevant lines covered (96.29%)

605.96 hits per line

stripe / stripe-ruby / 3530 / 1
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3530.1 (2.3)

stripe / stripe-ruby / 3530 / 1 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3530.1 (2.3)

stripe / stripe-ruby / 3530 / 1
97%
master: 97%

README BADGES
x