3530
97%

Ran 07 Nov 2019 10:19PM UTC

Jobs 5

Files 297

Run time 3min

Badge

Embed ▾

pending completion

Build # 3530

Build Type

push

travis-ci

Committed by

brandur-stripe

Commit Message

Add simple instrumentation callback (#870)

* Add simple instrumentation callback

We used to insert Faraday::Request::Instrumentation into our Faraday middleware
stack to be able to instrument Stripe calls with StatsD. With Faraday being
removed in version 5, this required some rework. This commit implements a simple
callback system that can be used with any kind of instrumentation system.

* Add a topic to Stripe::Instrumentation notifications

... and a :request topic to subscribe to

* Use a RequestEvent value object instead of positional args in callback

This way the RequestLogContext object doesn't get exposed externally. Since the
same value object can be received by multiple subscribers it is frozen to
prevent accidental mutations across threads.

* Relocate tests for instrumentation and add more tests

Run Details

5874 of 6105 relevant lines covered (96.22%)

2370.38 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3530.1 (2.3)	07 Nov 2019 10:19PM UTC	96.29	Travis Job 3530.1
2	3530.2 (2.4)	07 Nov 2019 10:19PM UTC	96.29	Travis Job 3530.2
3	3530.3 (2.5)	07 Nov 2019 10:19PM UTC	96.29	Travis Job 3530.3
4	3530.4 (2.6)	07 Nov 2019 10:19PM UTC	96.26	Travis Job 3530.4
5	3530.5 (jruby-9.2.7.0)	07 Nov 2019 10:22PM UTC	0.0	Travis Job 3530.5

Source Files on build 3530

Detailed source file information is not available for this build.

stripe / stripe-ruby / 3530
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3530

stripe / stripe-ruby / 3530 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3530

stripe / stripe-ruby / 3530
97%

README BADGES
x