1
94%
master: 96%

Ran 01 Nov 2019 01:53PM UTC

Files 128

Run time 16s

Badge

Embed ▾

Committed 01 Nov 2019 01:47PM UTC coverage: 94.012%. Remained the same

Job # 2.6.3, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_6.0.gemfile

Build Type

Pull #3210

travis-ci

Committed by

web-flow

Commit Message

Fix the case where username is nil, not whodunnit

I encounter the problem where paper_trails's whodunnit isn't displayed.
It turned out that `username` method returns nil.
`try` method returns nil when there's no method, so when user doesn't have `email` method,
`@user_class.find(@version.whodunnit).try(:email)` returns nil.
Then, try this out:
`nil rescue nil || :foo`
This returns nil, surprisingly.
This means if user doesn't have email method, username is always nil.
So my fix is like below:
`(nil rescue nil) || :foo`
This returns `:foo` as expected.

Pull Request Pull Request #3210: Fix the case where username is nil, not whodunnit

Coverage Stats

3344 of 3557 relevant lines covered (94.01%)

7412.49 hits per line

sferik / rails_admin / 2779 / 1
94%
master: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2779.1 (2.6.3, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_6.0.gemfile)

sferik / rails_admin / 2779 / 1 94% master: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2779.1 (2.6.3, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_6.0.gemfile)

sferik / rails_admin / 2779 / 1
94%
master: 96%

README BADGES
x