• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

sferik / rails_admin / 2779
94%
master: 96%

Build:
Build:
LAST BUILD BRANCH: ci
DEFAULT BRANCH: master
Ran 01 Nov 2019 01:52PM UTC
Jobs 14
Files 1459
Run time 28min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2779

Pull #3210

travis-ci

web-flow
Fix the case where username is nil, not whodunnit

I encounter the problem where paper_trails's whodunnit isn't displayed.
It turned out that `username` method returns nil.
`try` method returns nil when there's no method, so when user doesn't have `email` method,
`@user_class.find(@version.whodunnit).try(:email)` returns nil.
Then, try this out:
`nil rescue nil || :foo`
This returns nil, surprisingly.
This means if user doesn't have email method, username is always nil.
So my fix is like below:
`(nil rescue nil) || :foo`
This returns `:foo` as expected.
Pull Request #3210: Fix the case where username is nil, not whodunnit

1 of 1 new or added line in 1 file covered. (100.0%)

39524 of 41759 relevant lines covered (94.65%)

80701.37 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2779.1 (2.6.3, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_6.0.gemfile) 01 Nov 2019 01:53PM UTC 0
94.01
Travis Job 2779.1
2 2779.2 (2.2.10, CI_ORM=mongoid, gemfiles/rails_5.0.gemfile) 01 Nov 2019 01:52PM UTC 0
90.95
Travis Job 2779.2
3 2779.3 (2.2.10, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_5.0.gemfile) 01 Nov 2019 01:52PM UTC 0
92.73
Travis Job 2779.3
4 2779.4 (2.3.8, CI_ORM=mongoid, gemfiles/rails_5.1.gemfile) 01 Nov 2019 01:59PM UTC 0
90.87
Travis Job 2779.4
5 2779.5 (2.3.8, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_5.1.gemfile) 01 Nov 2019 01:53PM UTC 0
92.68
Travis Job 2779.5
6 2779.6 (2.4.5, CI_ORM=mongoid, gemfiles/rails_5.2.gemfile) 01 Nov 2019 01:57PM UTC 0
90.87
Travis Job 2779.6
7 2779.7 (2.4.5, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_5.2.gemfile) 01 Nov 2019 01:59PM UTC 0
93.85
Travis Job 2779.7
8 2779.8 (2.5.5, CI_ORM=mongoid, gemfiles/rails_5.2.gemfile) 01 Nov 2019 01:58PM UTC 0
90.87
Travis Job 2779.8
9 2779.9 (2.5.5, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_5.2.gemfile) 01 Nov 2019 01:59PM UTC 0
93.85
Travis Job 2779.9
10 2779.10 (2.6.3, CI_ORM=active_record CI_DB_ADAPTER=mysql2, gemfiles/rails_6.0.gemfile) 01 Nov 2019 02:06PM UTC 0
94.01
Travis Job 2779.10
11 2779.11 (2.6.3, CI_ORM=active_record CI_DB_ADAPTER=postgresql CI_DB_USERNAME=postgres, gemfiles/rails_6.0.gemfile) 01 Nov 2019 02:04PM UTC 0
94.01
Travis Job 2779.11
12 2779.12 (jruby-9.2.7.0, CI_ORM=mongoid, gemfiles/rails_5.2.gemfile) 01 Nov 2019 02:07PM UTC 0
90.47
Travis Job 2779.12
13 2779.13 (jruby-9.2.7.0, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_5.2.gemfile) 01 Nov 2019 02:10PM UTC 0
93.07
Travis Job 2779.13
16 2779.16 (jruby-head, CI_ORM=active_record CI_DB_ADAPTER=sqlite3, gemfiles/rails_5.2.gemfile) 01 Nov 2019 02:17PM UTC 0
93.07
Travis Job 2779.16
Source Files on build 2779
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2779
  • Pull Request #3210
  • PR Base - master (#2777)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc