3
97%
master: 97%

Ran 31 Oct 2019 04:54PM UTC

Files 97

Run time 8s

Badge

Embed ▾

Committed 31 Oct 2019 04:53PM UTC coverage: 96.218% (+0.009%) from 96.209%

Job # 2.5

Build Type

push

travis-ci

Committed by

ob-stripe

Commit Message

Raise an error when requests params are invalid (#874)

There are two kinds of API operations: collection and element specific.
The signature between the two is slightly different:
  - **collection**: (params, opts)
  - **element specific**: (id, params, opts)

If a user doesn't realize the difference, they may attempt to use the
collection signature when performing an element specific operation like:
```
Stripe::PaymentIntent.cancel('pi_1234', 'sk_test_key')
 # Results in an error: NoMethodError: undefined method `key?' for "sk_test"
```

The resulting error message isn't very useful for debugging.

Instead,this PR adds a message letting the user know what it's expecting:
`request params should be either a Hash or nil (was a String)`

Run Details

1959 of 2036 relevant lines covered (96.22%)

618.24 hits per line

stripe / stripe-ruby / 3513 / 3
97%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3513.3 (2.5)

stripe / stripe-ruby / 3513 / 3 97% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3513.3 (2.5)

stripe / stripe-ruby / 3513 / 3
97%
master: 97%

README BADGES
x