3513
97%

Ran 31 Oct 2019 04:54PM UTC

Jobs 5

Files 194

Run time 3min

Badge

Embed ▾

pending completion

Build # 3513

Build Type

push

travis-ci

Committed by

ob-stripe

Commit Message

Raise an error when requests params are invalid (#874)

There are two kinds of API operations: collection and element specific.
The signature between the two is slightly different:
  - **collection**: (params, opts)
  - **element specific**: (id, params, opts)

If a user doesn't realize the difference, they may attempt to use the
collection signature when performing an element specific operation like:
```
Stripe::PaymentIntent.cancel('pi_1234', 'sk_test_key')
 # Results in an error: NoMethodError: undefined method `key?' for "sk_test"
```

The resulting error message isn't very useful for debugging.

Instead,this PR adds a message letting the user know what it's expecting:
`request params should be either a Hash or nil (was a String)`

Run Details

3804 of 3958 relevant lines covered (96.11%)

2439.74 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3513.1 (2.3)	31 Oct 2019 04:54PM UTC	96.22	Travis Job 3513.1
2	3513.2 (2.4)	31 Oct 2019 04:54PM UTC	96.22	Travis Job 3513.2
3	3513.3 (2.5)	31 Oct 2019 04:54PM UTC	96.22	Travis Job 3513.3
4	3513.4 (2.6)	31 Oct 2019 04:54PM UTC	96.19	Travis Job 3513.4
5	3513.5 (jruby-9.2.7.0)	31 Oct 2019 04:57PM UTC	0.0	Travis Job 3513.5

Source Files on build 3513

Detailed source file information is not available for this build.

stripe / stripe-ruby / 3513
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3513

stripe / stripe-ruby / 3513 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3513

stripe / stripe-ruby / 3513
97%

README BADGES
x