nmstate / nmstate / 3261 / 1

Ran 29 Oct 2019 08:06PM UTC

Files 34

Run time 2s

Badge

Embed ▾

Committed 29 Oct 2019 07:19PM UTC coverage: 81.633% (-0.09%) from 81.726%

Job # DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type integ --pytest-args='-x'"

Build Type

push

travis-ci

Committed by

EdDev

Commit Message

ovs api: drop port's "type" attribute

OVS port "type" attribute is redundant. It can be currently set to "system" or
"internal", but these can be easily deduced from desired and current state. With
this patch we drop the attribute from the API, so we don't keep redundant
information and make schema more streamlined.

No other nmstate interface type requires users to specify slave type (both bond
and linux-bridge require the name only).

OVS bridge schema would change from:

```yaml
interfaces:
- name: ovs-br0
  type: ovs-bridge
  state: up
  bridge:
    port:
    - name: eth3
      type: system
```

To:

```yaml
interfaces:
- name: ovs-br0
  type: ovs-bridge
  state: up
  bridge:
    port:
    - name: eth3
```

https://nmstate.atlassian.net/browse/NMSTATE-248

Note that no changes were needed to implement this, apart from dropping the
"type" from reporting, schema and tests.

This API change is backwardly compatible for the `apply` action. If a user
specifies port's "type", it will be ignored. The "type" won't be reported
anymore in `show` action.

Signed-off-by: Petr Horacek <phoracek@redhat.com>

Run Details

2480 of 3038 relevant lines covered (81.63%)

0.82 hits per line

nmstate / nmstate / 3261 / 1

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3261.1 (DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type integ --pytest-args='-x'")

nmstate / nmstate / 3261 / 1

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3261.1 (DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type integ --pytest-args='-x'")

README BADGES
x