3261

Ran 29 Oct 2019 07:21PM UTC

Jobs 6

Files 299

Run time 44min

Badge

Embed ▾

pending completion

Build # 3261

Build Type

push

travis-ci

Committed by

EdDev

Commit Message

ovs api: drop port's "type" attribute

OVS port "type" attribute is redundant. It can be currently set to "system" or
"internal", but these can be easily deduced from desired and current state. With
this patch we drop the attribute from the API, so we don't keep redundant
information and make schema more streamlined.

No other nmstate interface type requires users to specify slave type (both bond
and linux-bridge require the name only).

OVS bridge schema would change from:

```yaml
interfaces:
- name: ovs-br0
  type: ovs-bridge
  state: up
  bridge:
    port:
    - name: eth3
      type: system
```

To:

```yaml
interfaces:
- name: ovs-br0
  type: ovs-bridge
  state: up
  bridge:
    port:
    - name: eth3
```

https://nmstate.atlassian.net/browse/NMSTATE-248

Note that no changes were needed to implement this, apart from dropping the
"type" from reporting, schema and tests.

This API change is backwardly compatible for the `apply` action. If a user
specifies port's "type", it will be ignored. The "type" won't be reported
anymore in `show` action.

Signed-off-by: Petr Horacek <phoracek@redhat.com>

Run Details

17382 of 26484 relevant lines covered (65.63%)

0.66 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3261.1 (DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type integ --pytest-args='-x'")	29 Oct 2019 08:06PM UTC	81.63	Travis Job 3261.1
2	3261.2 (DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type format")	29 Oct 2019 07:21PM UTC		Travis Job 3261.2
3	3261.3 (DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type lint")	29 Oct 2019 07:22PM UTC		Travis Job 3261.3
4	3261.4 (DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type unit_py27")	29 Oct 2019 07:22PM UTC	66.19	Travis Job 3261.4
5	3261.5 (DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type unit_py36")	29 Oct 2019 07:22PM UTC	65.96	Travis Job 3261.5
6	3261.6 (DOCKER_IMAGE=nmstate/fedora-nmstate-dev testflags="--test-type unit_py37")	29 Oct 2019 07:24PM UTC	65.96	Travis Job 3261.6

Source Files on build 3261

Detailed source file information is not available for this build.

nmstate / nmstate / 3261

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3261

nmstate / nmstate / 3261

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3261

README BADGES
x