• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kimmobrunfeldt / nap / 148 / 5
99%
master: 98%

Build:
Build:
LAST BUILD BRANCH: patch-1
DEFAULT BRANCH: master
Ran 18 Oct 2019 12:58PM UTC
Files 2
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

18 Oct 2019 12:57PM UTC coverage: 98.113%. First build
148.5

Pull #15

travis-ci

web-flow
Fix URL joining with Python 3.7

Possibly something's changed with `urllib.parse`, but definitely the URL joining tests where the baseurl does _not_ end in a slash were failing on my Ubuntu 18.04 Python 3.7. That is to say, that version works like this:

```py
urljoin("http://example.com/api", "foo") == "http://example.com/foo"
urljoin("http://example.com/api", "/foo") == "http://example.com/foo"
urljoin("http://example.com/api/", "foo") == "http://example.com/foo"
urljoin("http://example.com/api/", "/foo") == "http://example.com/api/foo"
```

I think in terms of the nap API, the final case is the only one that is "right", so this change always ensures that is the way we work.
Pull Request #15: Fix URL joining with Python 3.7

1 of 2 branches covered (50.0%)

52 of 53 relevant lines covered (98.11%)

0.98 hits per line

Source Files on job 148.5
  • Tree
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 145
  • Travis Job 148.5
  • 024ae19e on github
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc