• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kimmobrunfeldt / nap / 148
99%
master: 98%

Build:
Build:
LAST BUILD BRANCH: patch-1
DEFAULT BRANCH: master
Ran 18 Oct 2019 12:58PM UTC
Jobs 3
Files 4
Run time 54s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
148

Pull #15

travis-ci

web-flow
Fix URL joining with Python 3.7

Possibly something's changed with `urllib.parse`, but definitely the URL joining tests where the baseurl does _not_ end in a slash were failing on my Ubuntu 18.04 Python 3.7. That is to say, that version works like this:

```py
urljoin("http://example.com/api", "foo") == "http://example.com/foo"
urljoin("http://example.com/api", "/foo") == "http://example.com/foo"
urljoin("http://example.com/api/", "foo") == "http://example.com/foo"
urljoin("http://example.com/api/", "/foo") == "http://example.com/api/foo"
```

I think in terms of the nap API, the final case is the only one that is "right", so this change always ensures that is the way we work.
Pull Request #15: Fix URL joining with Python 3.7

3 of 4 branches covered (75.0%)

2 of 2 new or added lines in 1 file covered. (100.0%)

105 of 106 relevant lines covered (99.06%)

2.94 hits per line

Jobs
ID Job ID Ran Files Coverage
2 148.2 18 Oct 2019 12:58PM UTC 0
98.11
Travis Job 148.2
5 148.5 18 Oct 2019 12:58PM UTC 0
98.11
Travis Job 148.5
6 148.6 18 Oct 2019 12:58PM UTC 0
98.11
Travis Job 148.6
Source Files on build 148
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #148
  • Pull Request #15
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc