1
79%
master: 79%

Ran 17 Oct 2019 01:53AM UTC

Files 579

Run time 32s

Badge

Embed ▾

Committed 17 Oct 2019 01:45AM UTC coverage: 76.995% (+0.09%) from 76.91%

Job # 4020.1

Build Type

push

travis-ci

Committed by

jtopjian

Commit Message

avoid reauthentication loops (#1746)

* avoid reauthentication loops

It does not make sense to reauthenticate multiple times for a single
request. When the backing service returns 401 for a brand-new token,
reauthenticating again will just send us into an infinite loop.

Closes #1745.

* rewrite ProviderClient.Reauthenticate()

The old implementation has several places where the reauth mutex is
unlocked before being locked again. This allows concurrent goroutines to
glitch through reauthentication without the token having changed at all.

Since mutexes and esp. RW mutexes are incredibly hard to get right, I
propose this alternate implementation that coordinates concurrent
Reauthenticate calls with channels.

* add testcase for reauthentication loop avoidance

Coverage Stats

17702 of 22991 relevant lines covered (77.0%)

2.6 hits per line

gophercloud / gophercloud / 4020 / 1
79%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4020.1

gophercloud / gophercloud / 4020 / 1 79% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4020.1

gophercloud / gophercloud / 4020 / 1
79%
master: 79%

README BADGES
x