4020
79%

Ran 17 Oct 2019 01:52AM UTC

Jobs 4

Files 1158

Run time 4min

Badge

Embed ▾

Committed 17 Oct 2019 01:45AM UTC coverage: 76.995% (+0.09%) from 76.91%

Build # 4020

Build Type

push

travis-ci

Committed by

jtopjian

Commit Message

avoid reauthentication loops (#1746)

* avoid reauthentication loops

It does not make sense to reauthenticate multiple times for a single
request. When the backing service returns 401 for a brand-new token,
reauthenticating again will just send us into an infinite loop.

Closes #1745.

* rewrite ProviderClient.Reauthenticate()

The old implementation has several places where the reauth mutex is
unlocked before being locked again. This allows concurrent goroutines to
glitch through reauthentication without the token having changed at all.

Since mutexes and esp. RW mutexes are incredibly hard to get right, I
propose this alternate implementation that coordinates concurrent
Reauthenticate calls with channels.

* add testcase for reauthentication loop avoidance

Run Details

35404 of 45982 relevant lines covered (77.0%)

10.4 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4020.1	17 Oct 2019 01:53AM UTC	77.0	Travis Job 4020.1
2	4020.2	17 Oct 2019 01:53AM UTC	77.0	Travis Job 4020.2
3	4020.3	17 Oct 2019 01:52AM UTC	77.0	Travis Job 4020.3
4	4020.4	17 Oct 2019 01:55AM UTC	77.0	Travis Job 4020.4

Source Files on build 4020

Detailed source file information is not available for this build.

gophercloud / gophercloud / 4020
79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4020

gophercloud / gophercloud / 4020 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4020

gophercloud / gophercloud / 4020
79%

README BADGES
x